Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Move CRM event creation to tasker #18370

Merged
merged 76 commits into from
Jan 17, 2025
Merged

Conversation

joeauyeung
Copy link
Contributor

@joeauyeung joeauyeung commented Dec 25, 2024

What does this PR do?

  • Moves CRM event creation to the tasker

https://www.loom.com/share/a8338f139c1c4c8ca524af91f808b531

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Create an event type with a CRM
  • In the feature flags enable creating CRM events in tasker
  • Create a booking under the event type
    • The CRM event should not be created
  • Hit the internal tasker cron endpoint
  • The CRM event should be created

@github-actions github-actions bot added the ❗️ .env changes contains changes to env variables label Dec 25, 2024
@joeauyeung joeauyeung changed the base branch from main to upgrade-jsforce-v3 December 25, 2024 00:23
@keithwillcode keithwillcode added consumer core area: core, team members only labels Dec 25, 2024
Copy link

vercel bot commented Dec 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 6:21pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 6:21pm

sean-brydon and others added 16 commits January 14, 2025 16:15
* fix: disable sending sms when email is present

* fix: update test
* fix: error-page.tsx related lint errors

* fix: lint no continue-on-error

* Adding more lint fixes

* Bring back annotate code linting results

* Bring back linting continue-on-error

* Slimline lint
…#18639)

* fix eslint config

* fix

* add it to dev dep

* fix

* sync eslint version

* force ts-node to compile our ESLint plugin's TS files into CommonJS (which ESLint requires)

* fix some lint errors

* fix lint errors

* remove duplicate classname

* make @typescript-eslint/ban-types a warn for packages/trpc files

* fix lint errors in trpc

* fix lint errors in trpc - 2

* fix

* fix

* fix lint warnings
* potential fix: layout shift

* fix lint error
* chore: sync with main

* feat: update translations via @replexica

---------

Co-authored-by: Replexica <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Jan 14, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
8 out of 9 committers have signed the CLA.

✅ Udit-takkar
✅ joeauyeung
✅ ThyMinimalDev
✅ nizzyabi
✅ kart1ka
✅ keithwillcode
✅ hbjORbj
✅ emrysal
❌ calcom-bot
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments 🙏🏽

packages/core/EventManager.ts Show resolved Hide resolved
@github-actions github-actions bot marked this pull request as draft January 14, 2025 23:28
@joeauyeung joeauyeung linked an issue Jan 15, 2025 that may be closed by this pull request
@zomars zomars marked this pull request as ready for review January 16, 2025 18:21
@github-actions github-actions bot added the Urgent Created by Linear-GitHub Sync label Jan 16, 2025
@dosubot dosubot bot added this to the v4.10 milestone Jan 16, 2025
@joeauyeung joeauyeung merged commit 6561b92 into main Jan 17, 2025
37 of 39 checks passed
@joeauyeung joeauyeung deleted the move-salesforce-to-tasker branch January 17, 2025 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only crm-apps area: crm apps, salesforce, hubspot, close.com, sendgrid ❗️ .env changes contains changes to env variables ❗️ migrations contains migration files performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive ready-for-e2e Urgent Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-5027] Move CRM event creation to tasker