Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workflow id cache internal external enabled #6568

Conversation

arzonus
Copy link
Contributor

@arzonus arzonus commented Dec 18, 2024

What changed?
history.workflowIDCacheInternalEnabled and history.workflowIDCacheExternalEnabled have been removed

Why?
They've been enabled for sometime and the logic should be enabled by default

How did you test it?
Unit tests

@dkrotx
Copy link
Member

dkrotx commented Dec 18, 2024

Correct, I remember we introduced this purely to have an idea if it is safe to have the cache.
Cache with a small (a couple of second) TTL should always be fine since if perform requests to so many workflow-ids, we should certainly have a space to track them which is a waaaay smaller footprint.

@arzonus arzonus force-pushed the remove-workflow-id-cache-internal-external-enabled branch from 5c1514b to eb558cd Compare January 6, 2025 09:47
@arzonus arzonus merged commit e369936 into cadence-workflow:master Jan 6, 2025
17 checks passed
@arzonus arzonus deleted the remove-workflow-id-cache-internal-external-enabled branch January 6, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants