Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement simd_f64x2_arith for pulley #9917

Merged
merged 1 commit into from
Dec 31, 2024
Merged

feat: Implement simd_f64x2_arith for pulley #9917

merged 1 commit into from
Dec 31, 2024

Conversation

takaebato
Copy link
Contributor

@takaebato takaebato commented Dec 31, 2024 •
edited
Loading

Part of #9783

This PR implemented the following f64x2 SIMD instructions and made the "spec_testsuite/simd_f64x2_arith.wast" tests pass.

  • vsubf64x2
  • vmulf64x2
  • vdivf64x2
  • vnegf64x2

@takaebato takaebato force-pushed the add-simd_f64x2_arith branch from dcd4f5f to 4a00bc8 Compare December 31, 2024 07:34
@takaebato takaebato marked this pull request as ready for review December 31, 2024 08:23
@takaebato takaebato requested review from a team as code owners December 31, 2024 08:23
@takaebato takaebato requested review from abrown and fitzgen and removed request for a team December 31, 2024 08:23
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator pulley Issues related to the Pulley interpreter labels Dec 31, 2024
@github-actions GitHub Actions
Copy link

Subscribe to Label Action

cc @fitzgen

This issue or pull request has been labeled: "cranelift", "pulley"

Thus the following users have been cc'd because of the following labels:

  • fitzgen: pulley

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

alexcrichton
alexcrichton approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexcrichton alexcrichton added this pull request to the merge queue Dec 31, 2024
Merged via the queue into bytecodealliance:main with commit 5ca3715 Dec 31, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

@abrown abrown Awaiting requested review from abrown abrown is a code owner automatically assigned from bytecodealliance/wasmtime-compiler-reviewers

@fitzgen fitzgen Awaiting requested review from fitzgen fitzgen is a code owner automatically assigned from bytecodealliance/wasmtime-core-reviewers

Assignees
No one assigned
Labels
cranelift Issues related to the Cranelift code generator pulley Issues related to the Pulley interpreter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takaebato @alexcrichton