Make Pulley pass simd_f32x4_arith.wast
#9897
Open
+51
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds float SIMD instructions on 4 lanes (f32x4) for subtraction, multiplication, division, and negation. `vtrunc32x4` and `vmuli32x4` were used as basis on how to organize things.
To be exact: `spec_testsuite/simd_f32x4_arith.wast` has been removed from the should fail list for Pulley.
github-actions
bot
added
cranelift
Subscribe to Label Actioncc @fitzgen
This issue or pull request has been labeled: "cranelift", "pulley"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
pulley/src/lib.rs
Outdated
Comment on lines
814
to
815
| /// `low128(dst) = low128(src1) - low128(src2)` | ||
| vsub32x4 = Vsub32x4 { operands: BinaryOperands<VReg> }; |
There was a problem hiding this comment.
Mind using f32x4 in the opcodes (e.g. vsubf32x4) to clearly indicate that it's for floats and not integers?
Specifically: - "vsub32x4" -> "vsubf32x4" - "vmul32x4" -> "vmulf32x4" - "vdiv32x4" -> "vdivf32x4"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helping towards issue #9783.
This PR makes Pulley pass
spec_testsuite/simd_f32x4_arith.wast, by adding f32x4 instructions for subtraction, negation, multiplication, and division.Random notes:
pulley/src/lib.rsare based on what is done withvtrunc32x4.vmuli32x4.ftrunc32,vtrunc32x4, andvtrunc64x2are together, butftrunc64isn't near there.fat the end, e.g.vtrunc32x4vs.vabsf32x4.