Override component model Lower::store_list and Lift::load_list for f32/f64
#9892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
wasmtime:api
dicej
requested changes
Jan 2, 2025
| // alignment and sizing meaning that these assertions here are | ||
| // not truly necessary but are instead double-checks. | ||
| // | ||
| // Note that we're casting a `[u8]` slice to `[$integer]` (with |
There was a problem hiding this comment.
This paragraph (and the code that follows) refers to $integer, but we really care about $float, right? We should rewrite this to talk about floating point numbers instead of integers, e.g. "all u8 patterns are valid $float patterns since $float is a IEEE 754 floating point type."
| let byte_size = list.len * mem::size_of::<$integer>(); | ||
| let bytes = &cx.memory()[list.ptr..][..byte_size]; | ||
|
|
||
| // The canonical ABI requires that everything is aligned to its |
There was a problem hiding this comment.
Again, these comments should be updated to discuss floating point types rather than integer types.
| // case as all `u8` patterns are valid `$integer` patterns | ||
| // since `$integer` is an integral type. | ||
| let dst = &mut cx.as_slice_mut()[offset..][..items.len() * Self::SIZE32]; | ||
| let (before, middle, end) = unsafe { dst.align_to_mut::<$integer>() }; |
There was a problem hiding this comment.
Suggested change
| let (before, middle, end) = unsafe { dst.align_to_mut::<$integer>() }; | |
| let (before, middle, end) = unsafe { dst.align_to_mut::<$float>() }; |
Presumably the alignment of e.g. f32 and u32 should be the same, but we might as well be precise here (and in similar code below).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added overrides for
Lower::store_listandLift::load_listfor floating point numbers to reduce overhead when passing or returninglist<f32>andlist<f64>to/from components.I based this on the respective implementation for integers.