smith: Fix types recorded in ref.func
#1965
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a minor issue in `wasm-smith` when generating the `ref.func` instruction when the GC proposal is disabled but shared-everything-threads is enabled. In this situation all `ref.func` instructions were recorded as `RefType::FUNCREF` but this wasn't correct for shared function types. The logic here is applicable both with and without the GC proposal is enabled so the precise type is always pushed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a minor issue in
wasm-smithwhen generating theref.funcinstruction when the GC proposal is disabled but shared-everything-threads is enabled. In this situation allref.funcinstructions were recorded asRefType::FUNCREFbut this wasn't correct for shared function types. The logic here is applicable both with and without the GC proposal is enabled so the precise type is always pushed now.