-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wasm-pkg-common crate #25
Conversation
1d64105
to
8b1f207
Compare
Just getting around to reviewing, but still going thru. I think we can safely drop the backward compatible well-known logic / fields. We aren't relying on the behavior in our install instructions yet. And usage is very minimal for these tools. Can coordinate making the change. |
We can drop it in a future change; it just reduces the amount of coordination needed between various moving pieces. |
I was going to wait until I had some integration work done with this, but given that #29 depends on this now I'll just rebase what exists now for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me
This PR includes:
Registry
(domain)PackageRef
(namespace + name)Label
(lowercase kebab)Config
, with package->registry mappings and individual registry configurationRegistryMetadata
, representing the content of/.well-known/wasm-pkg/registry.json
I want to solidify a config format as at least a medium-term compatibility guarantee; we can always introduce a config file versioning scheme for revisions later if needed, but its nice to avoid too much backward-compat code.