Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch to remove nightly channel requirement for cargo #241

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jlb6740
Copy link
Collaborator

@jlb6740 jlb6740 commented Jun 6, 2023

Can't remember now what problem prompted the creation of this issue #239 but this patch is to remove the nightly requirement for cargo building and running of benchmarks.

@jlb6740 jlb6740 changed the title Patch to remove nightly channel rquirement for cargo when building or… Patch to remove nightly channel requirement for cargo Jun 6, 2023
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ a rebase on top of the ackerman fix

Copy link
Collaborator

@abrown abrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Searching around in the repository for "nightly", I see additional uses in .github/workflows and several other places. I think it would make sense to remove those as well since that way we will (1) avoid confusing users and (2) make sure in CI that +nightly is in fact not needed.

@abrown
Copy link
Collaborator

abrown commented Jul 7, 2023

I don't think we can actually merge this. Once I removed nightly from CI we get failures related to the precision crate missing something on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants