[draft] Add borrowing for fs_utf8::Dir #361
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to start using
fs_utf8::Dir
, but not in a "big bang" fashion where I wholesale convert the entire codebase. It feels normal and natural to have a non-utf8Dir
instance and maybe sometimes just want to "view" it as utf8.At an efficiency level, having to create a new owned fd for this feels unnecessary.
This sketches out an implementation where we can also support borrowing an existing fd.
This doesn't compile, but before I do a lot more typing on this - consider it an RFC. Is this a good direction?