Fix NPE in Input.poll() introduced with 9481fd1

After some reordering of the startup process in the above mentioned
commit, no updated instance of Input with a non-null ControllerInfo
got created, resulting in a NPE in the poll() method.

In order to prevent this problem, a new instance of Input gets created
after GLFW initialization with a ControllerInfo instance.

In addition, multiple defensive checks are introduced.

src/main/java/de/bwravencl/controllerbuddy/gui/Main.java

@@ -1057,7 +1057,7 @@ public void windowOpened(final WindowEvent e) {
 			}
 		});
 
-		onControllersChanged(optionalPresentControllers.orElse(Collections.emptyList()), true);
+		onControllersChanged(optionalPresentControllers.orElseGet(Collections::emptyList), true);
 
 		// noinspection resource
 		taskRunner.run((Runnable) () -> GLFW.glfwSetJoystickCallback((jid, event) -> {
@@ -2364,14 +2364,23 @@ private void onControllersChanged(final List<ControllerInfo> presentControllers,
 		if (!controllerConnected) {
 			selectedController = null;
 			setSelectedControllerAndUpdateInput(null, null);
-		} else if (selectedController == null) {
-			setSelectedControllerAndUpdateInput(presentControllers.getFirst(), null);
-
-			if (isAutoRestartOutput()) {
-				restartOutput = switch (lastRunModeType) {
-				case NONE, CLIENT -> false;
-				case LOCAL, SERVER -> true;
-				};
+		} else {
+			final ControllerInfo controller;
+			if (selectedController != null && presentControllers.contains(selectedController)) {
+				controller = selectedController;
+			} else {
+				controller = presentControllers.getFirst();
+			}
+
+			if (selectedController == null || (input != null && !Objects.equals(input.getController(), controller))) {
+				setSelectedControllerAndUpdateInput(controller, null);
+
+				if (isAutoRestartOutput()) {
+					restartOutput = switch (lastRunModeType) {
+					case NONE, CLIENT -> false;
+					case LOCAL, SERVER -> true;
+					};
+				}
 			}
 		}
 
@@ -2596,6 +2605,10 @@ public void setOverlayText(final String text) {
 	}
 
 	private void setSelectedController(final ControllerInfo controller) {
+		if (Objects.equals(selectedController, controller)) {
+			return;
+		}
+
 		selectedController = controller;
 
 		if (controller != null) {
@@ -2688,7 +2701,7 @@ private void startClient() {
 	private void startLocal() {
 		lastRunModeType = RunModeType.LOCAL;
 
-		if (selectedController == null || isRunning()) {
+		if (selectedController == null || input.getController() == null || isRunning()) {
 			return;
 		}
 
@@ -2715,7 +2728,7 @@ private void startOverlayTimerTask() {
 	private void startServer() {
 		lastRunModeType = RunModeType.SERVER;
 
-		if (selectedController == null || isRunning()) {
+		if (selectedController == null || input.getController() == null || isRunning()) {
 			return;
 		}
 

src/main/java/de/bwravencl/controllerbuddy/input/Input.java

@@ -346,6 +346,8 @@ public void moveAxis(final VirtualAxis virtualAxis, final float targetValue) {
 	}
 
 	public boolean poll() {
+		Objects.requireNonNull(controller, "Field controller must not be null");
+
 		final var currentTime = System.currentTimeMillis();
 
 		axisToEndSuspensionTimestampMap.values().removeIf(timestamp -> timestamp < currentTime);

src/main/java/de/bwravencl/controllerbuddy/runmode/RunMode.java

@@ -51,8 +51,12 @@ final void controllerDisconnected() {
 
 		Thread.startVirtualThread(() -> main.stopAll(true, !main.isAutoRestartOutput(), true));
 
-		log.log(Level.WARNING,
-				Main.assembleControllerLoggingMessage("Could not read from controller ", input.getController()));
+		final var controller = input.getController();
+		if (controller != null) {
+			log.log(Level.WARNING,
+					Main.assembleControllerLoggingMessage("Could not read from controller ", controller));
+		}
+
 		if (!main.isSkipControllerDialogs()) {
 			EventQueue.invokeLater(() -> GuiUtils.showMessageDialog(main, main.getFrame(),
 					Main.strings.getString("COULD_NOT_READ_FROM_CONTROLLER_DIALOG_TEXT"),