Optimized equals() implementation of KeyStroke and Mode classes

bwRavencl · Nov 9, 2023 · a81fead · a81fead
1 parent 15faeb6
commit a81fead
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 17 deletions.
diff --git a/src/main/java/de/bwravencl/controllerbuddy/input/KeyStroke.java b/src/main/java/de/bwravencl/controllerbuddy/input/KeyStroke.java
@@ -62,14 +62,9 @@ public Object clone() throws CloneNotSupportedException {
 
     @Override
     public boolean equals(final Object obj) {
-        if (this == obj) {
-            return true;
-        }
-        if (obj == null || getClass() != obj.getClass()) {
-            return false;
-        }
-        final var other = (KeyStroke) obj;
-        return Arrays.equals(keyCodes, other.keyCodes) && Arrays.equals(modifierCodes, other.modifierCodes);
+        return obj instanceof final KeyStroke keyStroke
+                && Arrays.equals(keyCodes, keyStroke.keyCodes)
+                && Arrays.equals(modifierCodes, keyStroke.modifierCodes);
     }
 
     public ScanCode[] getKeyCodes() {

diff --git a/src/main/java/de/bwravencl/controllerbuddy/input/Mode.java b/src/main/java/de/bwravencl/controllerbuddy/input/Mode.java
@@ -75,15 +75,7 @@ public Object clone() throws CloneNotSupportedException {
 
     @Override
     public boolean equals(final Object obj) {
-        if (this == obj) {
-            return true;
-        }
-        if (obj == null || getClass() != obj.getClass()) {
-            return false;
-        }
-        final var other = (Mode) obj;
-
-        return Objects.equals(uuid, other.uuid);
+        return obj instanceof final Mode mode && Objects.equals(uuid, mode.uuid);
     }
 
     public Set<IAction<?>> getAllActions() {