Make ecoinvent SSO client id configurable

[jsvgoncalves]

• As requested on Support for direct access flow will be removed #34, this sends a different client id to keycloak

#34 (comment)

[jsvgoncalves]

@asergios My guess is the client id isn't configured on keycloak yet?

[asergios]

@asergios My guess is the client id isn't configured on keycloak yet?

Just took care of it now, give it a try!

[jsvgoncalves]

@asergios there seems to still be something wrong in the reply back from apollo

[asergios]

@jsvgoncalves Sorry for the late reply. offline_access was indeed missing for the new client. I tested locally and seems to be fine now. Can you re-run the tests please?

[jsvgoncalves]

Sorry for the late reply. offline_access was indeed missing for the new client. I tested locally and seems to be fine now. Can you re-run the tests please?

Cool, tests are passing on CI too. https://github.com/brightway-lca/ecoinvent_interface/actions/runs/12008197826

[asergios]

We won't disable Direct Grant from apollo-ui for now to allow users of ei-interface to migrate to a more recent version where brightway-ei is used instead.

What do you think is a reasonable time for that? 3 months?

[cmutel]

What do you think is a reasonable time for that? 3 months?

Sure, that seems reasonable. Thanks a lot @asergios for your help, very much appreciated, and a good sign of cooperation across institutions!

[tngTUDOR]

This makes ecoinvent_interface provide a different client id to the target API, not a fix for #34

[tngTUDOR]

@jsvgoncalves did we miss some spots?

ecoinvent_interface/ecoinvent_interface/core.py

Line 189 in 76c5bad

"ecoinvent-api-client-library": "ecoinvent_interface",

ecoinvent_interface/ecoinvent_interface/core.py

Line 279 in 76c5bad

"ecoinvent-api-client-library": "ecoinvent_interface",

ecoinvent_interface/ecoinvent_interface/core.py

Line 299 in 76c5bad

"ecoinvent-api-client-library": "ecoinvent_interface",

Or there is no difference or trouble when using a client-id and a different api-library.

[jsvgoncalves]

@jsvgoncalves did we miss some spots?

ecoinvent_interface/ecoinvent_interface/core.py

Line 189 in 76c5bad

"ecoinvent-api-client-library": "ecoinvent_interface",

ecoinvent_interface/ecoinvent_interface/core.py

Line 279 in 76c5bad

"ecoinvent-api-client-library": "ecoinvent_interface",

ecoinvent_interface/ecoinvent_interface/core.py

Line 299 in 76c5bad

"ecoinvent-api-client-library": "ecoinvent_interface",

Or there is no difference or trouble when using a client-id and a different api-library.

Correct, the header that keycloak needs is the client_id. The ecoinvent-api-client-library was just a temporary nicety for ecoinvent folks to be able to tell the requests coming from this library apart, i.e. it's non-functional.