Skip to content
This repository has been archived by the owner on Aug 14, 2024. It is now read-only.

Settings App :( #314

Closed
wants to merge 2 commits into from
Closed

Settings App :( #314

wants to merge 2 commits into from

Conversation

yashash-pugalia
Copy link
Collaborator

The settings app has been added !!!

image image

#53 #100 #302 #303

Type of change

  • New feature (non-breaking change which adds functionality)

@blueedgetechno can you help the height of .nav_bottom & .tilesCont needs to be fixed

@yashash-pugalia yashash-pugalia added enhancement New feature or request help wanted Extra attention is needed Mega-Pull-Request A huge pull request DO-NOT-MERGE NPM new-feature in progress a pull request or an issue is in progress dependencies Pull requests that update a dependency file labels Feb 17, 2022
@win11bot
Copy link
Collaborator

⌛ Deploy Preview - Build in Progress
If you are part of our discord server then leave your discord name for a role.

@yashash-pugalia
Copy link
Collaborator Author

DO NOT MERGE WIP

@yashash-pugalia yashash-pugalia changed the title Settings App :) Settings App (no :) coz Posandu hates it) Feb 17, 2022
@yashash-pugalia yashash-pugalia changed the title Settings App (no :) coz Posandu hates it) Settings App :( Feb 17, 2022
@win11bot
Copy link
Collaborator

✔️ Deploy Preview for win11blue ready!
😎 Browse the preview: https://314.pr.blueedge.me !
🔨 If you experience an SSL issue then wait 2 minutes and try again.
🔍 Inspect the deploy log: https://github.com/blueedgetechno/win11React/actions/runs/1859528229

@blueedgetechno
Copy link
Owner

I have updated the code into the test branch, it should be live on https://dev.blueedge.me is few minutes, you can check that

@yashash-pugalia
Copy link
Collaborator Author

@andrewstech Tauri builds are failing :|

@yashash-pugalia
Copy link
Collaborator Author

yashash-pugalia commented Feb 17, 2022

I have updated the code into the test branch, it should be live on https://dev.blueedge.me is few minutes, you can check that

thank you

@yashash-pugalia
Copy link
Collaborator Author

154526979-9a130220-af5c-4cb2-a653-45f1eb369a82.mp4

this bug happens on adding height:100% to .settingsApp .restWindow :(

@blueedgetechno
Copy link
Owner

wait let me see

@blueedgetechno
Copy link
Owner

Oh this bug is of container-query-polyfill, it doesn't updates the div elements on react state change. I will ry to fix it in the morning, if possible otherwise we would have to exlude that package.

@yashash-pugalia
Copy link
Collaborator Author

yashash-pugalia commented Feb 17, 2022

Oh this bug is of container-query-polyfill, it doesn't updates the div elements on react state change. I will ry to fix it in the morning, if possible otherwise we would have to exlude that package.

but it is working fine in https://314.pr.blueedge.me

Win11.in.React.and.2.more.pages.-.Profile.1.-.Microsoft.Edge.2022-02-17.23-29-18.mp4

https://github.com/jsxtools/cqfill there is one more polyfill should we try that instead :)

@andrewstech andrewstech self-requested a review February 18, 2022 17:17
@yashash-pugalia
Copy link
Collaborator Author

@blueedgetechno for now I set a max-width to settings app ig we can make it more responsive for smaller screens later.

@win11bot
Copy link
Collaborator

✔️ Deploy Preview Updated!
🔍 Inspect the deploy log: https://github.com/blueedgetechno/win11React/actions/runs/1867707790
😎 Browse the preview: https://314.pr.blueedge.me !

@yashash-pugalia
Copy link
Collaborator Author

yashash-pugalia commented Feb 19, 2022

image

@andrewstech it did not update the preview

@win11bot
Copy link
Collaborator

✔️ Deploy Preview Updated!
🔍 Inspect the deploy log: https://github.com/blueedgetechno/win11React/actions/runs/1867707790
😎 Browse the preview: https://314.pr.blueedge.me !

@win11bot
Copy link
Collaborator

❌ DEPLOY PREVIEW BUILD HAS FAILED

@yashash-pugalia
Copy link
Collaborator Author

ok making new one againnnnnnn

@andrewstech
Copy link
Collaborator

It was due to the merge conflicts. If you close the pr the preview repo is then deleted. So closing then reopening with result in a failure.

@yashash-pugalia
Copy link
Collaborator Author

ohhk got it

@yashash-pugalia yashash-pugalia removed their assignment May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request help wanted Extra attention is needed in progress a pull request or an issue is in progress Mega-Pull-Request A huge pull request new-feature NPM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants