Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Conscrypt (+ other dependencies) #44

Merged
merged 8 commits into from
Dec 12, 2024
Merged

Update Conscrypt (+ other dependencies) #44

merged 8 commits into from
Dec 12, 2024

Conversation

ArnyminerZ
Copy link
Member

@ArnyminerZ ArnyminerZ commented Dec 8, 2024 •
edited
Loading

Gradle

  • Upgrade AGP to 8.7.3
  • Upgrade Kotlin to 2.1.0
  • Upgrade Conscrypt to 2.5.3
  • Upgrade JDK to 21
  • Upgrade Wrapper to 8.11
  • Upgrade SDK to 35 for sample app
  • Upgrade other dependencies

Github Actions

  • Upgrade JDK to 21
  • Got rid of unused matrix for tests

@ArnyminerZ ArnyminerZ linked an issue Dec 8, 2024 that may be closed by this pull request
Update Conscrypt (+ other dependencies) #43
Closed
@ArnyminerZ ArnyminerZ self-assigned this Dec 8, 2024
@ArnyminerZ ArnyminerZ added the refactoring Quality improvement of existing functions label Dec 8, 2024
@ArnyminerZ ArnyminerZ mentioned this pull request Dec 8, 2024
Merged
@ArnyminerZ ArnyminerZ marked this pull request as ready for review December 8, 2024 17:56
@ArnyminerZ ArnyminerZ requested a review from rfc2822 December 8, 2024 17:56
rfc2822
rfc2822 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍🏻

I have increased even to gradle 8.11.1 so that it's the same version as davx5, and generated a new wrapper (./gradle wrapper), which seems to be good for the github gradle action to detect it

@rfc2822 rfc2822 merged commit 65de909 into main Dec 12, 2024
3 checks passed
@rfc2822 rfc2822 deleted the 43-update-conscrypt-+-other-dependencies branch December 12, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfc2822 rfc2822 rfc2822 approved these changes

Assignees

@ArnyminerZ ArnyminerZ

Labels
refactoring Quality improvement of existing functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Conscrypt (+ other dependencies)
2 participants
@ArnyminerZ @rfc2822