Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic aromatic bond #738

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

padix-key
Copy link
Member

The kekulized form of aromatic bonds (i.e. their representations as single, double or triple bonds) is a visualization artifact: Chemically aromatic bonds have no bond order, but the pi-elections are delocalized in the entire pi-system.

For this reason I think it makes sense to lift the restriction to assign a bond to either of AROMATIC_SINGLE, AROMATIC_DOUBLE or AROMATIC_TRIPLE, but to allow a generic AROMATIC as well. Although, this might lead to some limitations in visualization, there are some advantages

  • Models predicting aromatic bonds do not necessarily need to know the kekulized form.
  • Some software does not internally represent aromatic bonds in kekulized form (e.g. RDKit).
  • SDF and PDBx support generic aromatic bonds as well.

Copy link

codspeed-hq bot commented Jan 17, 2025

CodSpeed Performance Report

Merging #738 will not alter performance

Comparing padix-key:aromatic-bond (2b0f6d9) with main (8138e0e)

Summary

✅ 59 untouched benchmarks

@padix-key padix-key merged commit b5c9df7 into biotite-dev:main Jan 20, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant