Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting the label_entity_id from the AtomArray, if annotated #732

Merged

Conversation

Croydon-Brixton
Copy link
Contributor

The label_entity_id is a standard category in cif files that relates the asym_id to the entity_id in entity_poly.

Currently, when writing out an AtomArray as cif file, entity_id's are always determined anew, giving new chains new entity id's even when they are actually the same entity (try e.g. 5ocm). This tiny PR allows to pass on the label_entity_id to writing out the structure. This category can already be loaded in AtomArrays via the extra_fields keyword argument.

Copy link

codspeed-hq bot commented Jan 5, 2025

CodSpeed Performance Report

Merging #732 will not alter performance

Comparing Croydon-Brixton:feat/allow_setting_entity_id (68e593a) with main (e76eb24)

Summary

✅ 47 untouched benchmarks

@padix-key
Copy link
Member

Hi, thanks for the PR. This seems like a sensible change to me, at least for now. In the future I would prefer to elevate entity_id to an optional annotation array (e.g. like charge or b_factor).

I assume this is ready to be merged?

@Croydon-Brixton
Copy link
Contributor Author

I agree, adding entity_id as optional annotation would be great!

And yes, ready to be merged 👍

@padix-key
Copy link
Member

Let's wait until tomorrow to see if anyone has an objection 👍

@Croydon-Brixton
Copy link
Contributor Author

That sounds good to me!

@padix-key padix-key merged commit 318db78 into biotite-dev:main Jan 8, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants