Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing labels to number input #1855

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

jorgemoya
Copy link
Contributor

What/Why?

Fixes an accessibility issue of missing labels.

image

Testing

Lighthouse no longer mentions this issue.

@jorgemoya jorgemoya requested a review from a team as a code owner January 6, 2025 21:30
Copy link

changeset-bot bot commented Jan 6, 2025

⚠️ No Changeset found

Latest commit: 6fc2290

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 9:32pm
catalyst-soul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 9:32pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Jan 6, 2025 9:32pm
catalyst-au ⬜️ Ignored (Inspect) Jan 6, 2025 9:32pm
catalyst-uk ⬜️ Ignored (Inspect) Jan 6, 2025 9:32pm

@jorgemoya jorgemoya merged commit c6cc0a0 into soul/main Jan 7, 2025
8 checks passed
@jorgemoya jorgemoya deleted the pdp-add-labels-buttons branch January 7, 2025 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants