Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial Klevu integration #1854

Open
wants to merge 1 commit into
base: integrations/klevu
Choose a base branch
from

Conversation

jerrypena1
Copy link

What/Why?

This is the initial integration of Klevu webcomponents into Catalys

@jerrypena1 jerrypena1 requested a review from a team as a code owner January 6, 2025 19:45
Copy link

changeset-bot bot commented Jan 6, 2025

⚠️ No Changeset found

Latest commit: a1d97eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 6, 2025

@jerrypena1 is attempting to deploy a commit to the BigCommerce Platform Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@matthewvolk matthewvolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one! Thanks Juan 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only review comment is to do with this file - and I think you probably already saw it coming from what you mentioned in your README 🙂

This file contains the KlevuInit component which needs two attributes specific to your Klevu account `apiKey` & `url`. 

Is there any chance we can replace the hard coded apiKey and url with a NEXT_PUBLIC_ environment variable? This will help with developers wanting to swap out keys, but will also help with the OCC deployment - we can programmatically add these variables potentially during deployment.

This is my only change requested, this PR looks good for approval after this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants