Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default ghref for CLI to @bigcommerce/catalyst-core@latest #1846

Closed
wants to merge 1 commit into from
Closed

Set default ghref for CLI to @bigcommerce/catalyst-core@latest #1846

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/create-catalyst/src/commands/create.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,11 @@ export const create = new Command('create')
.option('--access-token <token>', 'BigCommerce access token')
.option('--channel-id <id>', 'BigCommerce channel ID')
.option('--storefront-token <token>', 'BigCommerce storefront token')
.option('--gh-ref <ref>', 'Clone a specific ref from the source repository')
.option(
'--gh-ref <ref>',
'Clone a specific ref from the source repository',
'@bigcommerce/catalyst-core@latest',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would've thought this was set to main before?

Is there a place where main is hardcoded that we need to change? Or was it just using the GitHub default branch and thus now it would be canary so by always passing a value for --gh-ref, even if the default, then the default GitHub branch won't be used implicitly anymore?

)
.option('--reset-main', 'Reset the main branch to the gh-ref')
.option('--repository <repository>', 'GitHub repository to clone from', 'bigcommerce/catalyst')
.option('--env <vars...>', 'Arbitrary environment variables to set in .env.local')
Expand Down
Loading