feat: visually editable PDP #1808
Draft
+17,121
−5,383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore(core): use next canary and enable ppr * fix: use suggested functions over deprecated ones * chore(core): update tailwind config and layout to use Soul config * fix: eslint issues * chore(core): add roboto mono font * chore(core): add @/vibes/* path in tsconfig * feat(core): add FeaturedProductsList component and use in Homepage (#1673) * feat(core): add FeaturedProductsCarousel and use in Homepage (#1675) * feat(core): add best selling products to Hompage (#1676) * chore: bump components to include latest Streamable util (#1681) * chore(core): use next canary and enable ppr * feat: replace catalyst homepage slideshow * refactor: updated slideshow structure based on PR feedback * feat: add translations for homepage slider * fix: slide not in view when element inside is focused --------- Co-authored-by: Jorge Moya <[email protected]>
agurtovoy
force-pushed
the
aleksey/vib-1043-component-theming
branch
3 times, most recently
from
624ef9d to
0fd8e93
Compare
Base automatically changed from
aleksey/vib-1043-component-theming
to
soul/integrations/makeswift
December 31, 2024 17:10
This commits also updates: - Make the Shape prop required. Makeswift supports this by default. - Add default values to height and weight that matches the Soul default values. - Move the banner id prop to be after allowClose. - Rename and move some variables.
agurtovoy
force-pushed
the
aleksey/vib-908-pdp-visual-editing
branch
from
84742ae to
203bfc2
Compare
agurtovoy
force-pushed
the
aleksey/vib-908-pdp-visual-editing
branch
from
203bfc2 to
b70653e
Compare
agurtovoy
force-pushed
the
aleksey/vib-908-pdp-visual-editing
branch
from
b70653e to
32e566b
Compare
migueloller
force-pushed
the
soul/integrations/makeswift
branch
2 times, most recently
from
7ec8cda to
826b01e
Compare
agurtovoy
force-pushed
the
aleksey/vib-908-pdp-visual-editing
branch
from
32e566b to
6fc0a6d
Compare
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-n12omngfl-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
migueloller
force-pushed
the
soul/integrations/makeswift
branch
from
826b01e to
b2f5a9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Make product detail page visually editable.
Testing
Kapture.2024-12-25.at.21.53.44.mp4