1849 metabase dump fix #1864
Merged
1849 metabase dump fix #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VSerain
reviewed
Nov 14, 2023
| ]) | ||
| .toArray(); | ||
|
|
||
| await collection.updateMany( |
There was a problem hiding this comment.
Je comprend pas trop cette partie la ? On supprime le user des logs ducoup ?
There was a problem hiding this comment.
Ce qu'on supprime c'est un artefact. En gros ya deux types de logs :
- les logs où un utilisateur est connecté
- les logs où aucun utilisateur n'est connecté
Le aggregate :
- fait un join avec la table user
- remplit
meta.req.user._idavec la valeur qui va bien
Pour le cas 1. c'est tout bon.
Mais pour le cas 2, écrire undefined dans meta.req.user._id ça crée un objet meta.req.user qui n'était pas là et dont on ne veut pas. Je n'ai pas trouvé de moyen de ne pas le créer, donc je le renlève après.
There was a problem hiding this comment.
si mon explication te convient on merge
mxmeunier
approved these changes
Nov 14, 2023
VSerain
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1849