Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: query down instead of up #45

Merged
merged 2 commits into from
May 28, 2024
Merged

refactor: query down instead of up #45

merged 2 commits into from
May 28, 2024

Conversation

bennypowers
Copy link
Owner

@bennypowers bennypowers commented May 26, 2024

Closes #38

test: whitespace and mininit

This removes tests for one awful corner case: if you have in a single
file both expressions `/(\d)/` and `/\d*(\d)/`, the second pattern's
regexplanation will *sometimes* erroneously repeat the heading "capture
group 1", but you can clear this up by hovering a different regexp first

This case is weird enough that I'm choosing to ignore it for now
@bennypowers bennypowers force-pushed the refactor/query-down branch from 6e01f7e to 8a39f8d Compare May 28, 2024 17:50
fix: lookaround narratives

fix: don't debounce

refactor: remove last global state

refactor: destructure apis

BREAKING CHANGES:
- require tree-sitter-regexp 0.21
- require nvim 0.10
- replace `narrative.separator` with `narrative.indentation_string`
- change `component.depth` to `component.capture_depth` in `narrative.indentation_string` function
@bennypowers bennypowers force-pushed the refactor/query-down branch from 8a39f8d to 2ee73c1 Compare May 28, 2024 17:53
@bennypowers bennypowers merged commit 41c1b90 into main May 28, 2024
2 checks passed
@bennypowers bennypowers deleted the refactor/query-down branch May 28, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rexexplainer: loop exceeded 1000 at node start_tag
1 participant