Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smartplaylist: change option --extm3u to --output #5053

Merged

Conversation

mgoltzsche
Copy link
Contributor

@mgoltzsche mgoltzsche commented Dec 15, 2023

The boolean flags --extm3u and --no-extm3u are replaced with a string option --output=m3u|m3u8.
This reduces the amount of options and allows to evolve the CLI to support more playlist output formats in the future (e.g. JSON) without polluting the CLI at that point.

This is a follow-up of #5046.
Relates to #5048.

To Do

  • Documentation. (If you've added a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)
  • Tests. (Very much encouraged but not strictly required.)

@mgoltzsche mgoltzsche marked this pull request as draft December 15, 2023 22:09
@mgoltzsche mgoltzsche force-pushed the change-smartplaylist-extm3u-option branch from 2faab14 to ce3e7e6 Compare December 15, 2023 22:22
@mgoltzsche mgoltzsche changed the title smartplaylist: change option --extm3u to --format smartplaylist: change option --extm3u to --output Dec 15, 2023
@mgoltzsche
Copy link
Contributor Author

mgoltzsche commented Dec 15, 2023

I renamed the option from --format to --output now to avoid confusion with the option with the same name within beets' ls command and to allow #5048 to define the --format option instead.

@mgoltzsche mgoltzsche marked this pull request as ready for review December 15, 2023 22:25
@mgoltzsche mgoltzsche force-pushed the change-smartplaylist-extm3u-option branch from ce3e7e6 to 0cde586 Compare December 15, 2023 22:29
The boolean flags `--extm3u` and `--no-extm3u` are replaced with a string option `--output=m3u|m3u8`.
This reduces the amount of options and allows to evolve the CLI to support more playlist output formats in the future (e.g. JSON) without polluting the CLI at that point.
@mgoltzsche mgoltzsche force-pushed the change-smartplaylist-extm3u-option branch from 0cde586 to 385c05f Compare December 15, 2023 23:23
@Serene-Arc Serene-Arc merged commit adf4b97 into beetbox:master Dec 16, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants