Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [274]: Requested URL is incorrect when PostHog host includes a path #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bcheidemann
Copy link

💡 Motivation and Context

Fixes PostHog#274
Fixes PostHog/posthog-flutter#128

💚 How did you test it?

  1. Add unit tests asserting the correct behaviour and asserting preservation of existing related behaviour
  2. Run make test to ensure all tests passing
  3. Run make build to ensure the build is passing

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed. (I believe this is not needed)
  • No breaking change or entry added to the changelog. (assuming from the wording that I should not update the changelog)

@bcheidemann
Copy link
Author

bcheidemann commented Dec 18, 2024

@marandaneto @ioannisj please let me know if you'd like any changes made to this PR 🙂 I've tried to follow the conventions in your codebase as far as possible so hopefully I'm not too far off! However, this is my first time writing Swift, so I'd especially value any feedback you have for me - particularly around writing idiomatic Swift code.

Also, I'm assuming the new version of posthog-ios needs to be released before I can update posthog-flutter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requested URL is incorrect when PostHog host includes a path Posthog Flutter SDK is not sending any events
1 participant