Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring meson, make and pkgconfig versions via bzlmod exten… #1158

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jsharpe
Copy link
Member

@jsharpe jsharpe commented Jan 12, 2024

…sion

@jsharpe jsharpe force-pushed the toolchain_registration branch 5 times, most recently from 4190892 to db70d73 Compare March 31, 2024 22:32
@jsharpe jsharpe force-pushed the toolchain_registration branch 2 times, most recently from 61213e6 to 289b9c6 Compare April 21, 2024 15:02
Comment on lines 211 to 216
main = "@meson_src//:meson.py",
data = ["@meson_src//:runtime"],
main = "@meson_1.1.1_src//:meson.py",
data = ["@meson_1.1.1_src//:runtime"],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jheaff1 any ideas how I could avoid this hardcoded version number?
I want the end user to not have to do use_repo(tools, "meson_src") if they're using this macro which they currently have to; maybe we should make the toolchain variants have to be declared via a module extension and then generate this toolchain into the toolchain_hub e.g.

tools.meson(version = "1.1.1")
tools.meson(version = "1.1.1", requirements = ["@pypi__numpy"])

?

@jsharpe jsharpe requested review from jheaff1 and UebelAndre April 21, 2024 22:26
@jsharpe
Copy link
Member Author

jsharpe commented Apr 21, 2024

@jheaff1 @UebelAndre One part of this I'm yet to design is what the module extension should look like for selecting between preinstalled tools and prebuilt / built from source tools. Any ideas?

The extension API currently looks like this:

tools.cmake(version = "3.29.1")
tools.ninja(version = "1.12.0")

we could do something like:

tools.cmake(version = "3.29.1", allow_build_from_source = False)
tools.ninja(version = "1.11.1", use_prebuilt_binaries = False)
tools.pkgconfig(preinstalled_version = True)

but very much open to ideas on this.

@jsharpe jsharpe force-pushed the toolchain_registration branch from 69ccaa7 to bf9f34b Compare June 14, 2024 21:31
@jsharpe jsharpe force-pushed the toolchain_registration branch from bf9f34b to 727f549 Compare August 8, 2024 16:14
@jsharpe jsharpe force-pushed the toolchain_registration branch 3 times, most recently from 55ea21b to e83ede3 Compare November 18, 2024 23:33
@jsharpe jsharpe force-pushed the toolchain_registration branch from e83ede3 to b6938f8 Compare November 18, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant