Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NullPointerException on first deployer placed #80

Closed
wants to merge 0 commits into from
Closed

Fix NullPointerException on first deployer placed #80

wants to merge 0 commits into from

Conversation

ezraisw
Copy link
Contributor

@ezraisw ezraisw commented Dec 17, 2024 •
edited
Loading

Fixes #74 #76

There's a brief moment when a Deployer is placed where player (the internal fake player) is not yet initialized.

@ezraisw
Copy link
Contributor Author

ezraisw commented Dec 17, 2024 •
edited
Loading

By the way, industrial-revolution's artifacts seems to have been pulled off the repository. On local I built it without industrial-revolution.

@deirn
Copy link
Member

deirn commented Dec 17, 2024

Another reason I made Explosion :P.
Technically, the Omega Config dependency is already inside the Indrev jar; using Explosion to extract it would solve this issue.
I planned to move away from depending on Maven and just directly use the jar from CurseForge/Modrinth instead.

@deirn
Copy link
Member

deirn commented Dec 18, 2024

Can you rebase to the latest master?

@ezraisw ezraisw closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Caught unhandled exception with Create
2 participants
@ezraisw @deirn