gir: enforce gir dependency on gtkdoc header generation #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a result, introspection generation implicitly depends on python + python-lxml. configure now enforces that gtkdoc header generation is enabled if gir generated is selected. Both are still optional, unless --enable-introspection[=yes] is passed explicitly. Also, the gobject introspection check is now in a separate .m4 file.
|
@b4n ping |
|
Ping |
b4n
pushed a commit
that referenced
this pull request
Feb 15, 2023
Move search positions and layout to session.conf This will remember the x,y positions as well as the find/replace dialog expanders as part of session.conf. To implemenet this, a new interface configuration_add_session_group() is created that connects a StashGroup to session.conf.
b4n
pushed a commit
that referenced
this pull request
Feb 15, 2023
Like with all other stash groups, the VTE one is now set up in init_pref_groups(), along with the terminal various pref group. Since be739e2 ("session.conf split follow-up #3"), the send_cmd_prefix pref was read from the configuration before setting up the stash group, which caused the "Follow path of the current file" feature to crash Geany. I.e. the fix is to set up the stash group even earlier. In my optionion, it's also beneficial that the overall stash groups do not depend on loading libvte or not. For example, previously the terminal various pref group was only added when loading libvte was not disabled. When it was disabled the end result was inconsistent with the manual. Now the terminal group appears unconditionally. Fixes be739e2 ("session.conf split follow-up #3") Fixes geany#3151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result, introspection generation implicitly depends on python +
python-lxml.
configure now enforces that gtkdoc header generation is enabled
if gir generated is selected. Both are still optional, unless
--enable-introspection[=yes] is passed explicitly.
Also, the gobject introspection check is now in a separate .m4 file.
Hopefully, this is the last bit necessary for geany#1112