Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes the
*_neon
functions replace their original scalar implementations. This (partially) resolves the divergence between the set of functions supported in Arm and in x86. There are still a few functions that are diverged -bignum_emontredc_8n_cdiff
andbignum_copy_row_from_table_*
which only exists in Arm - but all other functions are converged into one.The original scalar functions are moved to the
unopt/
directories. Their proofs are merged into the*_neon.ml
proofs, which are again renamed to the original*.ml
.All
_NEON
and_neon
suffixes are removed.Also, this patch applies the NIST P-256 optimized field operations to
p256_scalarmulbase
which was missing in the past.Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.