Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing generic parameter to ReadableStream type #6554

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add missing generic parameter to ReadableStream type #6554

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/types/src/serde.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ declare global {
/**
* @public
*/
export interface ReadableStream {}
export interface ReadableStream<R = any> {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this an issue if you have the dom or node types library installed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kuhe sorry for the late reply

This is how it's defined both in the DOM typings:

https://github.com/microsoft/TypeScript/blob/cb44488fcec4348a448434afbf2ebcbf2b423c61/src/lib/dom.generated.d.ts#L19086

and in the Node.js typings:

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/3c2bac796de55bd7fe6c00bab670829efa6fbc1e/types/node/stream/web.d.ts#L173

I have had no problems using it in our project that has the node typings installed, and I just tested adding DOM to libs and it works as well 👍

/**
* @public
*/
Expand Down
Loading