#220 Fix case-sensitivity of HTTP headers in models #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solution builds upon @jeromevdl 's solution of PR aws#234 to fix the issue of headers being case sensitive. Fixes @carlzogh 's comment regarding breaking changes in setHeaders.
|
Do you think that Thoughts @carlzogh @andclt @jeromevdl |
Personally I could agree to that too, since you can just as easily have it be package-private on a method level that way and that was the reason I thought of moving it to a package-private class to begin with |
carlzogh
reviewed
Jan 5, 2022
.../src/main/java/com/amazonaws/services/lambda/runtime/events/APIGatewayProxyRequestEvent.java
Outdated
Show resolved
Hide resolved
...n/java/com/amazonaws/services/lambda/runtime/events/ApplicationLoadBalancerRequestEvent.java
Show resolved
Hide resolved
...rc/main/java/com/amazonaws/services/lambda/runtime/events/APIGatewayV2WebSocketResponse.java
Outdated
Show resolved
Hide resolved
...da-java-tests/src/test/java/com/amazonaws/services/lambda/runtime/tests/EventLoaderTest.java
Outdated
Show resolved
Hide resolved
* Fix os compatibility test local builds on arm64 hosts * Extract log fetching and clean up to separate scripts
|
Hi @parawanderer, Can this be updated at written as a PR against the V4 branch? |
* optimize jar discovery * remove lambda implementation * return of no jars are found * use static final annon class instead * use static reference for consistency
) Bumps [gson](https://github.com/google/gson) from 2.8.5 to 2.8.9. - [Release notes](https://github.com/google/gson/releases) - [Changelog](https://github.com/google/gson/blob/master/CHANGELOG.md) - [Commits](google/gson@gson-parent-2.8.5...gson-parent-2.8.9) --- updated-dependencies: - dependency-name: com.google.code.gson:gson dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Carl Zogheib <[email protected]>
Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.10.0 to 2.12.6.1. - [Release notes](https://github.com/FasterXML/jackson/releases) - [Commits](https://github.com/FasterXML/jackson/commits) --- updated-dependencies: - dependency-name: com.fasterxml.jackson.core:jackson-databind dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Carl Zogheib <[email protected]> Co-authored-by: Alexander Smirnov <[email protected]>
Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.10.5.1 to 2.12.6.1. - [Release notes](https://github.com/FasterXML/jackson/releases) - [Commits](https://github.com/FasterXML/jackson/commits) --- updated-dependencies: - dependency-name: com.fasterxml.jackson.core:jackson-databind dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Carl Zogheib <[email protected]> Co-authored-by: Alexander Smirnov <[email protected]>
|
Hi @msailes I've taken a look and I believe I merged it in with the "events-v4-serialization-v2" branch, changed things in line with previous suggestions in this thread and updated all relevant tests/usages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #220
Description of changes:
This solution builds upon @jeromevdl 's solution of PR 234 to fix the
issue of headers being case sensitive. Fixes @carlzogh 's comment
regarding breaking changes in setHeaders.
This adds some extra unit tests, and reorders some of the added unit test assertions of the original PR, too
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.