Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Port CRT S3 translation mapping. #8959

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

aemous
Copy link
Contributor

@aemous aemous commented Oct 8, 2024

Description of changes:
Ports the following s3transfer PRs:

Description of tests:

  • All ported unit tests are passing
  • Manually tested the AWS CLI against the change. Below I run an upload via aws s3 cp to an S3 bucket that does not exist using a CRT client. The output can be compared before and after this change:

Before this change (generic error)

aws s3 cp workplace/aem278-submissions/README.md s3://test-fake-bucket
upload failed: workplace/aem278-submissions/README.md to s3://test-fake-bucket/README.md AWS_ERROR_S3_INVALID_RESPONSE_STATUS: Invalid response status from request

After this change (more specific error)

aws s3 cp workplace/aem278-submissions/README.md s3://test-fake-bucket 
upload failed: workplace/aem278-submissions/README.md to s3://test-fake-bucket/README.md An error occurred (NoSuchBucket) when calling the PutObject operation: The specified bucket does not exist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aemous aemous requested review from aws-sdk-python-automation and a team October 8, 2024 14:29
@aemous aemous changed the title Port CRT S3 translation mapping. [v2] Port CRT S3 translation mapping. Oct 8, 2024
Copy link
Contributor

@hssyoo hssyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CI passes on retry, 🏆

Copy link

@graebm graebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@aemous aemous merged commit e1190d5 into aws:v2 Oct 8, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants