Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Skip final RDS snapshot in SG for Pods #1218

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

niallthomson
Copy link
Contributor

What this PR does / why we need it:

There seems to be cases where the RDS final snapshot gets created when cleaning up the SG for Pods lab due to missing IAM permissions. This does not seem to happen in the automated tests.

This PR explicitly disables the final snapshot instead of changing the IAM permissions.

Which issue(s) this PR fixes:

Fixes #1201

Quality checks

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

netlify bot commented Jan 3, 2025

Deploy Preview for eks-workshop ready!

Name Link
🔨 Latest commit a9b54c6
🔍 Latest deploy log https://app.netlify.com/sites/eks-workshop/deploys/67782d994a8c1f00082d472a
😎 Deploy Preview https://deploy-preview-1218--eks-workshop.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@niallthomson niallthomson merged commit f8baf07 into main Jan 3, 2025
11 checks passed
@niallthomson niallthomson deleted the fix-rds-snapshot branch January 3, 2025 18:46
@niallthomson niallthomson added this to the Release 25/01 milestone Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant