qemu_vm: correct param name from driver_format to drive_format #3806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct parameter name should be drive_name that be defined in configuration files Signed-off-by: Yanan Fu <[email protected]>
|
@YongxueHong @PaulYuuu Call for your review , thanks ! In theory, it affect the pci bus for the cdrom. |
|
Mark it as draft, do not merge it. Although the change is full sure correct, but need investigate more about the possible regression issues which can work with the wrong setting before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct parameter name should be drive_name that be defined in configuration files
ID：1582
Signed-off-by: Yanan Fu [email protected]