Move unlock call to a background context in GC #2198
Merged
+63
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephschorr
force-pushed
the
gc-background-ctx
branch
from
8b33ada to
cfc3e7e
Compare
github-actions
bot
added
the
area/tooling
josephschorr
force-pushed
the
gc-background-ctx
branch
2 times, most recently
from
20c8720 to
780f704
Compare
tstirrat15
previously approved these changes
Jan 9, 2025
josephschorr
force-pushed
the
gc-background-ctx
branch
from
780f704 to
b1ceb39
Compare
josephschorr
force-pushed
the
gc-background-ctx
branch
3 times, most recently
from
216010f to
013f1ab
Compare
ecordell
reviewed
Jan 9, 2025
internal/datastore/common/gc.go
Outdated
| err := gc.UnlockAfterGCRun(ctx) | ||
| // NOTE: this uses a separate context to run the DB unlock logic, ensuring that | ||
| // a timeout in the parent context won't prevent a lock release. | ||
| err := gc.UnlockAfterGCRun(context.Background()) |
There was a problem hiding this comment.
wouldn't this be clearer?
err := gc.UnlockAfterGCRun()
and then the implementations for the datastores can handle it as appropriate (i.e. it may make sense to have an internal timeout and kill the session)
There was a problem hiding this comment.
Not sure if it is clearer (as a caller I'd expect a context), but I can document it
This ensures that if the GC operation times out, the unlock still can run
josephschorr
force-pushed
the
gc-background-ctx
branch
from
013f1ab to
e06fd9f
Compare
|
Updated |
ecordell
approved these changes
Jan 9, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that if the GC operation times out, the unlock still can run