fix atom-message-panel bug (error on message-panel/window close) #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@medardm Great to hear, I'm guessing you're not a maintainer who can merge this, though? |
|
Yes I am not a maintainer @pfandzelter, unfortunately. |
|
I could quite use this fix, the bug error pops up a lot for me. |
TheRealKANi
approved these changes
Jan 3, 2020
|
Got it working on my side too, will those changes be 'overwritten' on the next update? |
If you didn't use the apm development tools, the changes should be overwritten. Hopefully, this PR will be merged before the next update, though |
|
When will this be merged? This is a Major bug (at least to me) |
adamdevelop
approved these changes
Mar 11, 2020
|
@rgbkrk Please merge this? |
|
Done. Adding @pfandzelter as a maintainer as well. |
|
Great, thanks! |
|
Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1995, #1997 and #2002.
The atom-message-panel package was recently updated to include a fix on their side, but with just the version bump, the script window appears only once and never again after it's closed (as reported in several issues on their side as well, see tcarlsen/atom-message-panel/#91 and tcarlsen/atom-message-panel/#90).
Feel free to test this on your machines!