-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-export async-attributes #238
Conversation
Signed-off-by: Yoshua Wuyts <[email protected]>
Signed-off-by: Yoshua Wuyts <[email protected]>
4ee8fe2
to
038edc0
Compare
Signed-off-by: Yoshua Wuyts <[email protected]>
This PR and async-rs/async-attributes#8 have been updated to now use the I think merging this would actually be really nice, as we enable people to write some nicer-looking applications the way they could with Runtime, but we don't lose any performance in the base case. Coupled with the Screenshots |
Are these now stable attributes? I assume so and fine with that, but just making sure it's not an oversight. :) There's not much we can do wrong with these attributes - they're pretty straightforward, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but let's wait for @skade to also take a look.
Not necessarily, and I think we should be cautious. async-rs/async-attributes#11 and async-rs/async-attributes#9 actually should be resolved first. edit: I don't think we should be exposing that particular API. So another option is we punt |
Updated the PR to be exactly that. Thanks! |
Signed-off-by: Yoshua Wuyts <[email protected]>
Signed-off-by: Yoshua Wuyts <[email protected]>
Agree with everything you said 👍 |
ping for @skade |
@stjepang I would like to make this available in the next release; I'd like to propose we merge this. |
Closes #237. The docs don't render properly on this, but I think that's okay. Thanks!