Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for non-flakes #282

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RaitoBezarius
Copy link
Contributor

Via flake-compat.

Via flake-compat.

Signed-off-by: Raito Bezarius <[email protected]>
@astro
Copy link
Owner

astro commented Oct 8, 2024

Do you really need this?

@RaitoBezarius
Copy link
Contributor Author

I'm not sure there's an easy way to get access to the package set exposed, short of rewriting the flake.nix, right?

@RaitoBezarius
Copy link
Contributor Author

Happy to drop flake-compat if you prefer me to re-expose it via default.nix and re-import in the flake.nix directly.

@astro
Copy link
Owner

astro commented Oct 8, 2024

Yes, I'd prefer one dependency less in flake.lock for the case where flakes are not used :)

@RaitoBezarius
Copy link
Contributor Author

Okay, will send a more complicated PR for that, then :).

@astro
Copy link
Owner

astro commented Oct 11, 2024

Let me know if you encounter problems because if the other way becomes too many lines of code we should resort to the flake-compat solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants