Surround "#pragma clang" with checks for Clang #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbautin
added a commit
to yugabyte/SimSIMD
that referenced
this pull request
Sep 24, 2024
…GCC 12 and GCC 13 These changes were performed automatically by the following script: https://gist.githubusercontent.com/mbautin/9a9ec9933dd4daf954b2a878f48a8048/raw (generated by ChatGPT). See also ashvardanian#192.
mbautin
added a commit
to yugabyte/SimSIMD
that referenced
this pull request
Sep 28, 2024
…GCC 12 and GCC 13 These changes were performed automatically by the following script: https://gist.githubusercontent.com/mbautin/9a9ec9933dd4daf954b2a878f48a8048/raw (generated by ChatGPT). See also ashvardanian#192.
|
Thanks for the contribution, @mbautin! I think we should safeguard those pragmas symmetrically for both GCC and Clang. I will take your PR as a starting point and augment it with more |
ashvardanian
force-pushed
the
main-dev
branch
3 times, most recently
from
54ae495 to
fb1e864
Compare
ashvardanian
force-pushed
the
main-dev
branch
from
679a813 to
252fba7
Compare
ashvardanian
force-pushed
the
main-dev
branch
2 times, most recently
from
48ac9e4 to
5d9a219
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prevent compilation issues on GCC 12 and GCC13.
These changes were performed automatically by the following script: https://gist.githubusercontent.com/mbautin/9a9ec9933dd4daf954b2a878f48a8048/raw
(generated by ChatGPT).