Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace manual casts with new instanceof expression syntax #774

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

ascopes
Copy link
Owner

@ascopes ascopes commented Dec 28, 2024

No description provided.

@ascopes ascopes added the enhancement Optimisations and internal improvements in the codebase. label Dec 28, 2024
@ascopes ascopes self-assigned this Dec 28, 2024
Copy link

codecov bot commented Dec 28, 2024

Codecov Report

Attention: Patch coverage is 88.63636% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.16%. Comparing base (0dedcda) to head (e0717e9).
Report is 1 commits behind head on v5.

Files with missing lines Patch % Lines
.../jct/containers/impl/ModuleContainerGroupImpl.java 0.00% 2 Missing ⚠️
.../jct/workspaces/impl/AbstractManagedDirectory.java 0.00% 2 Missing ⚠️
...hub/ascopes/jct/workspaces/impl/WorkspaceImpl.java 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##               v5     #774      +/-   ##
==========================================
- Coverage   87.17%   87.16%   -0.01%     
==========================================
  Files          99       99              
  Lines        2932     2922      -10     
  Branches      229      230       +1     
==========================================
- Hits         2556     2547       -9     
+ Misses        329      328       -1     
  Partials       47       47              
Files with missing lines Coverage Δ
.../containers/impl/ContainerGroupRepositoryImpl.java 59.68% <100.00%> (-0.92%) ⬇️
...ithub/ascopes/jct/filemanagers/ModuleLocation.java 100.00% <100.00%> (ø)
...opes/jct/filemanagers/impl/JctFileManagerImpl.java 100.00% <100.00%> (ø)
...opes/jct/filemanagers/impl/PathFileObjectImpl.java 100.00% <100.00%> (ø)
...b/ascopes/jct/junit/AbstractCompilersProvider.java 100.00% <100.00%> (ø)
.../io/github/ascopes/jct/utils/ModuleDiscoverer.java 100.00% <100.00%> (ø)
...a/io/github/ascopes/jct/utils/ToStringBuilder.java 100.00% <100.00%> (ø)
...pes/jct/workspaces/impl/WrappingDirectoryImpl.java 85.18% <100.00%> (ø)
...hub/ascopes/jct/workspaces/impl/WorkspaceImpl.java 39.77% <66.66%> (+0.44%) ⬆️
.../jct/containers/impl/ModuleContainerGroupImpl.java 22.22% <0.00%> (ø)
... and 1 more

@ascopes ascopes force-pushed the task/v5-use-instanceof-improvements branch from fd768c8 to e0717e9 Compare December 28, 2024 11:44
@ascopes ascopes merged commit 87af518 into v5 Dec 28, 2024
9 checks passed
@ascopes ascopes deleted the task/v5-use-instanceof-improvements branch December 28, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Optimisations and internal improvements in the codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant