Fix GA/EA action

[SentryMan]

Also add maven cache

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.21%. Comparing base (a5bd97e) to head (a88cd56).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #766   +/-   ##
=======================================
  Coverage   87.21%   87.21%           
=======================================
  Files          99       99           
  Lines        2942     2942           
  Branches      229      229           
=======================================
  Hits         2566     2566           
  Misses        329      329           
  Partials       47       47           

[SentryMan]

Well I suppose it's only natural lombok would fail the EA build since they don't support a JDK until after it becomes GA

[ascopes]

We could update the Lombok example with a selector.groovy that filters out EA builds if you are able to determine that.

// src/it/lombok/selector.groovy
if (thisIsAnEaBuild()) {
  println("Lombok is not supported in EA builds")
  return false
}

return true

that'd allow you to keep this enabled. Maven Invoker would detect this automatically and just skip that test when it is detected.

Edit: example: https://github.com/ascopes/protobuf-maven-plugin/blob/main/protobuf-maven-plugin/src/it/scalapb-plugin/selector.groovy

[SentryMan]

it's both lombok and error prone

[ascopes]

Yeah, thought that'd be a problem. Do you know if the JDK has any descriptor of the version being early access (e g. in the Runtime.version() API)?

[SentryMan]

running

System.out.println(Runtime.version());

gives me 24-ea+28-3562

[ascopes]

Wonder if it is worth checking that with a regex just to disable the specific tests that are problematic... what do you think? Is testing against EA likely to provide additional benefit do you think?

[SentryMan]

you can catch potential issues before they happen and notify the JDK devs before GA if it's a JDK problem

[ascopes]

Might be worth adding then! I can take a look when I have some time unless you'd like to add it to this PR.

Thanks for fixing on such short notice, btw.