Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-721: Add overloads for workspaces APIs to support list types. #725

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

ascopes
Copy link
Owner

@ascopes ascopes commented Aug 26, 2024

Add overloads for workspaces APIs to support list types.

All varargs methods now are accompanied by an overload that consumes a java.util.List.

The previous varargs overloads are now handled as default methods in most cases, so this is a breaking API change to be bundled with v4.0.0.

Fixes GH-721.

@ascopes ascopes added new feature A new feature enhancement Optimisations and internal improvements in the codebase. labels Aug 26, 2024
@ascopes ascopes self-assigned this Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 47.05882% with 9 lines in your changes missing coverage. Please review.

Project coverage is 88.06%. Comparing base (013caa1) to head (bae79df).
Report is 2 commits behind head on main.

Files Patch % Lines
.../io/github/ascopes/jct/workspaces/FileBuilder.java 20.00% 4 Missing ⚠️
...opes/jct/workspaces/impl/DirectoryBuilderImpl.java 20.00% 4 Missing ⚠️
...ithub/ascopes/jct/workspaces/DirectoryBuilder.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #725      +/-   ##
==========================================
- Coverage   88.22%   88.06%   -0.17%     
==========================================
  Files          97       99       +2     
  Lines        3033     3042       +9     
  Branches      246      246              
==========================================
+ Hits         2676     2679       +3     
- Misses        310      316       +6     
  Partials       47       47              
Files Coverage Δ
.../jct/containers/impl/OutputContainerGroupImpl.java 49.05% <100.00%> (ø)
...in/java/io/github/ascopes/jct/utils/FileUtils.java 100.00% <ø> (ø)
...ithub/ascopes/jct/workspaces/ManagedDirectory.java 100.00% <100.00%> (ø)
...va/io/github/ascopes/jct/workspaces/Workspace.java 93.75% <ø> (ø)
.../jct/workspaces/impl/AbstractManagedDirectory.java 45.71% <100.00%> (ø)
...b/ascopes/jct/workspaces/impl/FileBuilderImpl.java 48.83% <100.00%> (ø)
.../jct/workspaces/impl/MemoryFileSystemProvider.java 81.81% <100.00%> (ø)
...pes/jct/workspaces/impl/WrappingDirectoryImpl.java 85.18% <ø> (ø)
...ithub/ascopes/jct/workspaces/DirectoryBuilder.java 0.00% <0.00%> (ø)
.../io/github/ascopes/jct/workspaces/FileBuilder.java 20.00% <20.00%> (ø)
... and 1 more

@ascopes ascopes merged commit a436dab into main Aug 26, 2024
18 of 20 checks passed
@ascopes ascopes deleted the task/GH-721-add-new-overloads branch August 26, 2024 19:15
@ascopes ascopes added this to the v4.0.0 milestone Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Optimisations and internal improvements in the codebase. new feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add overloads to T first, T... rest methods
1 participant