Resolve Gradle configuration cache issues #730
+84
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerbertrand
force-pushed
the
tylerbertrand/resolve-configuration-cache-issues
branch
from
8b78c0d to
cdf6517
Compare
Replace AbstractAsciidoctorTask's direct reference to AsciidoctorJExtension with its individual properties in a configuration cache compatible fashion
tylerbertrand
force-pushed
the
tylerbertrand/resolve-configuration-cache-issues
branch
from
cdf6517 to
788b908
Compare
tylerbertrand
force-pushed
the
tylerbertrand/resolve-configuration-cache-issues
branch
from
bc47b5d to
9c00da9
Compare
…etters to use the internal getter to write through to the asciidoctorj extension
tylerbertrand
force-pushed
the
tylerbertrand/resolve-configuration-cache-issues
branch
from
9c00da9 to
b2a2537
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes the Gradle configuration caching issues originating from this project when executing
org.asciidoctor.gradle.jvm.AsciidoctorTask. There are some remaining issues, but those are caused by the grolifant library.Changes
The configuration caching issues in this project were primarily tasks referencing types incompatible with configuration caching. The references to these types were mostly held by
AsciidoctorJExtension, whichAbstractAsciidoctorTaskheld a reference to. To resolve this,AbstractAsciidoctorTasknow reads the neededAsciidoctorJExtensionproperties through providers, so that holding a direct reference toAsciidoctorJExtensionis no longer necessary. No input annotations were added to these providers to maintain parity with the current task behavior. The setters inAbstractAsciidoctorTaskthat write data through toAsciidoctorJExtensionnow obtain theAsciidoctorJExtensionthrough an@Internalgetter. This way, Gradle does not serializeAsciidoctorJExtensionas part of the config cache entry.Next Steps
The remaining configuration caching issues are shown in the following report.
The grolifant library will have to be updated or removed from this plugin to resolve these issues.