Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add logic for disabled policies #21347

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dhaiducek
Copy link

@dhaiducek dhaiducek commented Jan 2, 2025

Disabled policies were errantly reporting as "Progressing" since they have no status.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@dhaiducek dhaiducek requested a review from a team as a code owner January 2, 2025 15:22
Copy link

bunnyshell bot commented Jan 2, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@dhaiducek
Copy link
Author

/cc @JustinKuli

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.23%. Comparing base (8126508) to head (96fa7fe).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21347      +/-   ##
==========================================
+ Coverage   55.19%   55.23%   +0.03%     
==========================================
  Files         337      337              
  Lines       57058    57058              
==========================================
+ Hits        31496    31514      +18     
+ Misses      22863    22842      -21     
- Partials     2699     2702       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Disabled policies were errantly reporting as
"Progressing" since they have no status.

Signed-off-by: Dale Haiducek <[email protected]>
@dhaiducek dhaiducek force-pushed the fix-disabled-policy branch from 96fa7fe to d0a920b Compare January 2, 2025 16:17
@dhaiducek
Copy link
Author

CI failure here is unrelated to the PR--the CodeCov report failed:

info - 2025-01-02 17:00:00,466 -- Process Report creating complete
error - 2025-01-02 17:00:00,466 -- Report creating failed: {"message":"Token required because branch is protected"}
Error: Codecov:
                        Failed to properly create report: The process '/home/runner/work/_actions/codecov/codecov-action/b9fd7d16f6d7d1b5d2bec1a2887e65ceed900238/dist/codecov' failed with exit code 1

Copy link
Contributor

@JustinKuli JustinKuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @jannfis, since you approved my original contribution of these checks, can you take a quick look or suggest someone else that can help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants