fix(ui): Group Nodes breaks Kinds counts / views #21337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Surajyadav <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: Surajyadav <[email protected]>
Signed-off-by: Surajyadav <[email protected]>
andrii-korotkov-verkada
approved these changes
Jan 1, 2025
6 tasks
|
@andrii-korotkov-verkada @jsoref, I have submitted a membership request. Could you sponsor me? That would help draw attention to it. |
|
I can't, I don't think I'm a member (oddly). |
oh ok then 👍 |
dudo
pushed a commit
to dudo/argo-cd
that referenced
this pull request
Jan 18, 2025
* groupview-filter-fix Signed-off-by: Surajyadav <[email protected]> * count-logic-change Signed-off-by: Surajyadav <[email protected]> * lint-fixes Signed-off-by: Surajyadav <[email protected]> --------- Signed-off-by: Surajyadav <[email protected]> Signed-off-by: Brett C. Dudo <[email protected]>
revitalbarletz
pushed a commit
to revitalbarletz/argo-cd
that referenced
this pull request
Jan 20, 2025
* groupview-filter-fix Signed-off-by: Surajyadav <[email protected]> * count-logic-change Signed-off-by: Surajyadav <[email protected]> * lint-fixes Signed-off-by: Surajyadav <[email protected]> --------- Signed-off-by: Surajyadav <[email protected]>
flbla
pushed a commit
to flbla/argo-cd
that referenced
this pull request
Jan 20, 2025
* groupview-filter-fix Signed-off-by: Surajyadav <[email protected]> * count-logic-change Signed-off-by: Surajyadav <[email protected]> * lint-fixes Signed-off-by: Surajyadav <[email protected]> --------- Signed-off-by: Surajyadav <[email protected]> Signed-off-by: flbla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16039, #13577
In addition to the kind filter problem in group view there was also issue if someone tries to filter name of pods
Previously
the filter graph would look through the tree graph and check for predicate for every node and in case of grouping the individual child nodes(pods) were removed and replaced with podGroup making them unaccessible to the filter similarly for name and counts
before :
before-fix-for-group.mp4
after :
Grouping-filter-fixed.mp4
Checklist: