-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update go-github to use token #21292
chore: update go-github to use token #21292
Conversation
Signed-off-by: [email protected] <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: [email protected] <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21292 +/- ##
==========================================
- Coverage 55.25% 55.24% -0.01%
==========================================
Files 337 337
Lines 56940 56825 -115
==========================================
- Hits 31461 31395 -66
+ Misses 22801 22740 -61
- Partials 2678 2690 +12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Co-authored-by: Nitish Kumar <[email protected]> Signed-off-by: Adam Buran <[email protected]>
Signed-off-by: aburan28 <[email protected]>
Signed-off-by: aburan28 <[email protected]>
Signed-off-by: aburan28 <[email protected]>
Signed-off-by: aburan28 <[email protected]>
* minor change to use WithAuthToken Signed-off-by: [email protected] <[email protected]> * minor change to use WithAuthToken Signed-off-by: [email protected] <[email protected]> * Update applicationset/services/scm_provider/github.go Co-authored-by: Nitish Kumar <[email protected]> Signed-off-by: Adam Buran <[email protected]> * remove ctx from NewGithubProvider Signed-off-by: aburan28 <[email protected]> * remove ctx from NewGithubProvider Signed-off-by: aburan28 <[email protected]> * remove unused parameter Signed-off-by: aburan28 <[email protected]> * update readthedogs.yml to allow for builds Signed-off-by: aburan28 <[email protected]> --------- Signed-off-by: [email protected] <[email protected]> Signed-off-by: Adam Buran <[email protected]> Signed-off-by: aburan28 <[email protected]> Co-authored-by: Nitish Kumar <[email protected]> Signed-off-by: Brett C. Dudo <[email protected]>
* minor change to use WithAuthToken Signed-off-by: [email protected] <[email protected]> * minor change to use WithAuthToken Signed-off-by: [email protected] <[email protected]> * Update applicationset/services/scm_provider/github.go Co-authored-by: Nitish Kumar <[email protected]> Signed-off-by: Adam Buran <[email protected]> * remove ctx from NewGithubProvider Signed-off-by: aburan28 <[email protected]> * remove ctx from NewGithubProvider Signed-off-by: aburan28 <[email protected]> * remove unused parameter Signed-off-by: aburan28 <[email protected]> * update readthedogs.yml to allow for builds Signed-off-by: aburan28 <[email protected]> --------- Signed-off-by: [email protected] <[email protected]> Signed-off-by: Adam Buran <[email protected]> Signed-off-by: aburan28 <[email protected]> Co-authored-by: Nitish Kumar <[email protected]>
* minor change to use WithAuthToken Signed-off-by: [email protected] <[email protected]> * minor change to use WithAuthToken Signed-off-by: [email protected] <[email protected]> * Update applicationset/services/scm_provider/github.go Co-authored-by: Nitish Kumar <[email protected]> Signed-off-by: Adam Buran <[email protected]> * remove ctx from NewGithubProvider Signed-off-by: aburan28 <[email protected]> * remove ctx from NewGithubProvider Signed-off-by: aburan28 <[email protected]> * remove unused parameter Signed-off-by: aburan28 <[email protected]> * update readthedogs.yml to allow for builds Signed-off-by: aburan28 <[email protected]> --------- Signed-off-by: [email protected] <[email protected]> Signed-off-by: Adam Buran <[email protected]> Signed-off-by: aburan28 <[email protected]> Co-authored-by: Nitish Kumar <[email protected]> Signed-off-by: flbla <[email protected]>
Minor change here to load the token for the github client using the WIthAuthToken method instead of using the x oauth2 library. This simplifies this section of code and removes the oauth2 dependency.
Checklist: