Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update go-github to use token #21292

Merged

Conversation

aburan28
Copy link
Contributor

@aburan28 aburan28 commented Dec 22, 2024

Minor change here to load the token for the github client using the WIthAuthToken method instead of using the x oauth2 library. This simplifies this section of code and removes the oauth2 dependency.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Copy link

bunnyshell bot commented Dec 22, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.24%. Comparing base (f6a84a4) to head (da8695f).
Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
applicationset/services/pull_request/github.go 66.66% 1 Missing ⚠️
applicationset/services/scm_provider/github.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21292      +/-   ##
==========================================
- Coverage   55.25%   55.24%   -0.01%     
==========================================
  Files         337      337              
  Lines       56940    56825     -115     
==========================================
- Hits        31461    31395      -66     
+ Misses      22801    22740      -61     
- Partials     2678     2690      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aburan28 aburan28 changed the title minor change to use WithAuthToken chore: update go-github to use token Dec 22, 2024
@aburan28 aburan28 marked this pull request as ready for review December 22, 2024 18:17
@aburan28 aburan28 requested a review from a team as a code owner December 22, 2024 18:17
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ishitasequeira ishitasequeira merged commit 9b17495 into argoproj:master Jan 16, 2025
27 checks passed
dudo pushed a commit to dudo/argo-cd that referenced this pull request Jan 18, 2025
* minor change to use WithAuthToken

Signed-off-by: [email protected] <[email protected]>

* minor change to use WithAuthToken

Signed-off-by: [email protected] <[email protected]>

* Update applicationset/services/scm_provider/github.go

Co-authored-by: Nitish Kumar <[email protected]>
Signed-off-by: Adam Buran <[email protected]>

* remove ctx from NewGithubProvider

Signed-off-by: aburan28 <[email protected]>

* remove ctx from NewGithubProvider

Signed-off-by: aburan28 <[email protected]>

* remove unused parameter

Signed-off-by: aburan28 <[email protected]>

* update readthedogs.yml to allow for builds

Signed-off-by: aburan28 <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>
Signed-off-by: Adam Buran <[email protected]>
Signed-off-by: aburan28 <[email protected]>
Co-authored-by: Nitish Kumar <[email protected]>
Signed-off-by: Brett C. Dudo <[email protected]>
revitalbarletz pushed a commit to revitalbarletz/argo-cd that referenced this pull request Jan 20, 2025
* minor change to use WithAuthToken

Signed-off-by: [email protected] <[email protected]>

* minor change to use WithAuthToken

Signed-off-by: [email protected] <[email protected]>

* Update applicationset/services/scm_provider/github.go

Co-authored-by: Nitish Kumar <[email protected]>
Signed-off-by: Adam Buran <[email protected]>

* remove ctx from NewGithubProvider

Signed-off-by: aburan28 <[email protected]>

* remove ctx from NewGithubProvider

Signed-off-by: aburan28 <[email protected]>

* remove unused parameter

Signed-off-by: aburan28 <[email protected]>

* update readthedogs.yml to allow for builds

Signed-off-by: aburan28 <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>
Signed-off-by: Adam Buran <[email protected]>
Signed-off-by: aburan28 <[email protected]>
Co-authored-by: Nitish Kumar <[email protected]>
flbla pushed a commit to flbla/argo-cd that referenced this pull request Jan 20, 2025
* minor change to use WithAuthToken

Signed-off-by: [email protected] <[email protected]>

* minor change to use WithAuthToken

Signed-off-by: [email protected] <[email protected]>

* Update applicationset/services/scm_provider/github.go

Co-authored-by: Nitish Kumar <[email protected]>
Signed-off-by: Adam Buran <[email protected]>

* remove ctx from NewGithubProvider

Signed-off-by: aburan28 <[email protected]>

* remove ctx from NewGithubProvider

Signed-off-by: aburan28 <[email protected]>

* remove unused parameter

Signed-off-by: aburan28 <[email protected]>

* update readthedogs.yml to allow for builds

Signed-off-by: aburan28 <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>
Signed-off-by: Adam Buran <[email protected]>
Signed-off-by: aburan28 <[email protected]>
Co-authored-by: Nitish Kumar <[email protected]>
Signed-off-by: flbla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants