-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: retch-http
-based HttpClient
implementation
#2787
Open
barjin
wants to merge
8
commits into
master
Choose a base branch
from
feat/retch-client
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+348
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
t-tooling
Issues with this label are in the ownership of the tooling team.
label
Jan 2, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Example usage: const crawler = new CheerioCrawler({
requestHandler: async ({ json }) => {
console.log(json);
},
httpClient: new RetchHttpClient({
browser: Browser.Firefox,
}),
proxyConfiguration: new ProxyConfiguration({
proxyUrls: ['http://auto:[email protected]:8000'],
}),
});
await crawler.run([
{
url: 'https://api.ipify.org/?format=json',
},
]); |
Aside from the code review - I'm unsure how the new package will be released. Is the process fully automatic? Do we need to mention this package in some config file? What should we name the package? |
it's all automated, as long as it's part of the workspace, it should just work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
@crawlee
-scope package, which exports anHttpClient
implementation based onretch-http
.The implementation is still rough around the edges - mostly based on https://github.com/apify-projects/node-curl-impersonate/blob/master/src/http-client.ts. Like the
curl-impersonate
client, this client doesn't yet offer native support for streamed responses.Related to #2756