fix(popover): refactor toggle and close handlers for controlled components #31792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Fix Detected |
|---|---|---|
 |
Unsafe visibility state access ▹ view |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopoverTrigger.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ✅ Issue Categories
Category Enabled Naming ✅ Database Operations ✅ Documentation ✅ Logging ✅ Error Handling ✅ Systems and Environment ✅ Objects and Data Structures ✅ Readability and Maintainability ✅ Asynchronous Processing ✅ Design Patterns ✅ Third-Party Libraries ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
| handleTogglePopover: togglePopover, | ||
| handleClosePopover: closePopover, | ||
| }; | ||
| const visible = isControlledComponent ? props.visible! : popoverVisible; |
There was a problem hiding this comment.
Unsafe visibility state access 
Tell me more
What is the issue?
Non-null assertion is used on props.visible without ensuring it exists for controlled components.
Why this matters
This could lead to runtime errors if the visible prop is not provided when the component is used in controlled mode.
Suggested change ∙ Feature Preview
Add a validation check or provide a default value:
const visible = isControlledComponent ? props.visible ?? false : popoverVisible;Chat with Korbit by mentioning @korbit-ai, and give a 👍 or 👎 to help Korbit improve your reviews.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
michael-s-molina
requested review from
justinpark,
kgabryje,
geido and
michael-s-molina
michael-s-molina
added
the
review:checkpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #25592
Added clearing of popoverLabel and hasCustomLabel states. Merged handlers that works with toggle/close from props and locally implemented in component to work with new column selectors and edit existing ones.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
Description by Korbit AI
What change is being made?
Refactor the
handleTogglePopoverandhandleClosePopoverfunctions to better accommodate controlled components withinColumnSelectPopoverTrigger.Why are these changes being made?
The changes ensure that
ColumnSelectPopoverTriggerhandles both controlled and uncontrolled component cases by delegating toggle and close functionality to external handlers when needed, enhancing flexibility and ensuring consistent behavior across different component states. This approach also consolidates logic, making maintenance easier, though it introduces dependency on the existence of externally provided handlers for controlled components.