[SPARK-48334] [CORE] Release RpcEnv when SparkContext Initialization Fails #49292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Jan 6, 2025
| @@ -721,6 +723,15 @@ class SparkContext(config: SparkConf) extends Logging { | |||
| } catch { | |||
| case NonFatal(e) => | |||
| logError("Error initializing SparkContext.", e) | |||
| if(_env == null && envCreated != null) { | |||
There was a problem hiding this comment.
How can this happen? I think the issue has to be understood thoroughly
There was a problem hiding this comment.
@HyukjinKwon I looked through the SparkContext creation again and here are my thoughts. There is a window where SparkEnv can be partially initialized (thus starting the RPC server) yet never assigned to _env in time for the usual shutdown logic to call _env.stop().
By stopping envCreated directly if _env remains null on exception, we can ensure that the RPC server (and other env resources) get shut down. That prevents the leftover port-blocking issue.
Please correct me if I'm wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If a SparkContext fails during initialization (for example, due to invalid Spark configs), the driver’s RpcEnv may have already started but never gets stopped, because SparkContext’s _env field is still null and _env.stop() is not invoked in the catch block. As a result, the RPC server port remains bound indefinitely in that process. This PR adds logic to ensure that if the RPC server is partially created and a SparkContext constructor error occurs, we properly shut down the RpcEnv so it does not remain open.
Why are the changes needed?
Does this PR introduce any user-facing change?
No. Internal fix only; no visible API changes.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No