Issue 31437 with keyword query error mysql #34163

Yash-cor · 2024-12-26T10:09:08Z

Changes proposed in this pull request:

Added DuplicateCommonTableExpressionAliasException to support with keyword binding.
This Issue is solved by the update in Sql binder in PR - #34141
Added WithSegmentBinderTest
Added with clause test in SQLBinderIT

Before committing this PR, I'm sure that I have checked the following options:

My code follows the code of conduct of this project.
I have self-reviewed the commit code.
I have (or in comment I request) added corresponding labels for the pull request.
I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
I have made corresponding changes to the documentation.
I have added corresponding unit tests for my changes.
I have updated the Release Notes of the current development version. For more details, see Update Release Note

…y and resolved the CheckTableExist error during With keyword Query execution

…31437_WITH_KEYWORD_QUERY_ERROR_MYSQL

strongduanmu · 2024-12-26T11:02:12Z

Hi @Yash-cor, can you sync master branch, and add sql bind test case for with statement.

Yash-cor · 2024-12-27T04:22:16Z

Hi @Yash-cor, can you sync master branch, and add sql bind test case for with statement.

Yeah sure

strongduanmu · 2024-12-30T01:21:40Z

RELEASE-NOTES.md

@@ -140,7 +143,6 @@
 1. Pipeline: Support page query for inventory dumper and data consistency streaming query
 1. Pipeline: Use case-insensitive identifiers to enhance the table metadata loader
 1. Pipeline: Support primary key columns ordering for standard pipeline table metadata loader
-1. Sharding: Optimize sharding table index name rewriting rules and remove unnecessary suffix rewriting - [#31171](https://github.com/apache/shardingsphere/issues/31171)


Why remove this release note?

Will resolve this.

strongduanmu · 2024-12-30T01:24:04Z

...he/shardingsphere/infra/binder/engine/segment/dml/expression/type/SubquerySegmentBinder.java

-        return new SubquerySegment(segment.getStartIndex(), segment.getStopIndex(), boundSelectStatement, segment.getText());
+        SubquerySegment result = new SubquerySegment(segment.getStartIndex(), segment.getStopIndex(), boundSelectStatement, segment.getText());
+        selectBinderContext.getCommonTableExpressionsSegmentsUniqueAliases().forEach(each -> {
+            ShardingSpherePreconditions.checkNotContains(binderContext.getCommonTableExpressionsSegmentsUniqueAliases(), each, () -> new UniqueCommonTableExpressionException(each.toString()));


Does this check happen in MySQL? If yes, please provide MySQL test results.

I have changed the logic for UniqueCommonTableAlias check
This check happens in MySQL but in ShardingSphere this check was happening while the query is executed in MySQL database so I have added this check during the creation of Query Context.

strongduanmu · 2024-12-30T01:24:25Z

...pache/shardingsphere/infra/binder/engine/segment/dml/from/type/SimpleTableSegmentBinder.java

@@ -85,6 +85,7 @@ public static SimpleTableSegment bind(final SimpleTableSegment segment, final SQ
        IdentifierValue databaseName = getDatabaseName(segment, binderContext);
        IdentifierValue schemaName = getSchemaName(segment, binderContext, databaseName);
        IdentifierValue tableName = segment.getTableName().getIdentifier();
+


Please
remove this useless blank line.

strongduanmu · 2024-12-30T01:25:08Z

...n/java/org/apache/shardingsphere/infra/binder/engine/segment/dml/with/WithSegmentBinder.java

            if (segment.isRecursive() && each.getAliasName().isPresent()) {
                externalTableBinderContexts.removeAll(new CaseInsensitiveString(each.getAliasName().get()));
            }
            bindWithColumns(each.getColumns(), boundCommonTableExpression);
            each.getAliasName().ifPresent(optional -> externalTableBinderContexts.put(new CaseInsensitiveString(optional), createWithTableBinderContext(boundCommonTableExpression)));
        }
+


Please remove useless blank line.

strongduanmu · 2024-12-30T01:25:40Z

.../java/org/apache/shardingsphere/infra/binder/engine/statement/SQLStatementBinderContext.java

@@ -47,6 +49,8 @@ public final class SQLStatementBinderContext {

    private final SQLStatement sqlStatement;

+    private final Set<CaseInsensitiveString> commonTableExpressionsSegmentsUniqueAliases = new HashSet<>();


Please use Collection<CaseInsensitiveString> to replace Set<CaseInsensitiveString>.

Besides, dou you think CaseInsensitiveSet is better?

Now I am using Collection<String> commonTableExpressionsSegmentsUniqueAliases = new CaseInsensitiveSet<>();

CaseInsensitiveSet will be better as it ease the overhead of creating the object in case of Set

strongduanmu · 2024-12-30T01:27:28Z

.../binder/src/test/java/org/apache/shardingsphere/infra/binder/with/WithSegmentBinderTest.java

+import static org.mockito.Mockito.when;
+import static org.mockito.Mockito.RETURNS_DEEP_STUBS;
+
+public class WithSegmentBinderTest {


Please add sql bind test in SQLBinderIT instead of this unit test.

A SQL test case is already present there for it will add some more.

strongduanmu · 2024-12-30T01:27:56Z

...pache/shardingsphere/infra/exception/kernel/syntax/UniqueCommonTableExpressionException.java

+    private static final long serialVersionUID = -8206891094419297634L;
+
+    public UniqueCommonTableExpressionException(final String alias) {
+        super(XOpenSQLState.SYNTAX_ERROR, 500, "Not unique table/alias: '%s'", alias);


Is this exception consistent with the database?

If yes, please update the exception document.

Yes this Error is present in MySQL with MySQl error code 1066
and SQLState as 42000 so do I have to create this exception somewhere else

strongduanmu · 2024-12-30T01:28:09Z

...pache/shardingsphere/infra/exception/kernel/syntax/UniqueCommonTableExpressionException.java

+import org.apache.shardingsphere.infra.exception.core.external.sql.sqlstate.XOpenSQLState;
+import org.apache.shardingsphere.infra.exception.core.external.sql.type.kernel.category.SyntaxSQLException;
+
+public final class UniqueCommonTableExpressionException extends SyntaxSQLException {


Please add java doc for this class.

strongduanmu · 2024-12-30T01:29:50Z

...main/java/org/apache/shardingsphere/sql/parser/statement/mysql/dml/MySQLDeleteStatement.java

@@ -38,6 +39,8 @@ public final class MySQLDeleteStatement extends DeleteStatement implements MySQL

    private ReturningSegment returningSegment;

+    private WithSegment withSegment;


Can you provide the documentation for MySQL DELETE WITH ?

For this class, you change the SQL parsing result, you need to add SQL Parser IT test to ensure that we handle withSegment

Will make these changes once the logic for the CTE's Unique Alias Name is clear.

…R_MYSQL

…RROR_MYSQL' into ISSUE_31437_WITH_KEYWORD_QUERY_ERROR_MYSQL

…with a different PR.

…R_MYSQL

…RROR_MYSQL' into ISSUE_31437_WITH_KEYWORD_QUERY_ERROR_MYSQL

Yash-cor added 8 commits December 24, 2024 15:03

Added the With Segment Binder which improves the working of With Quer…

8544d67

…y and resolved the CheckTableExist error during With keyword Query execution

Added the changes

1653664

Resolves Merge Conflicts

2029eaf

Merge

068962b

Added unique Alias Exception while using Common Table Expression

f973677

Fix Spotless error

027ea9f

Merge remote-tracking branch 'refs/remotes/origin/master' into ISSUE_…

6c8660a

…31437_WITH_KEYWORD_QUERY_ERROR_MYSQL

Added Release Notes

88a1300

Yash-cor added 5 commits December 27, 2024 18:05

Added SQL bind test case for WithSegmentBinder

e2e18ea

Added Release Notes

ab34b8e

Resolve Merge Conflict

6a2640c

Resolve Merge Conflict

2b0c960

Added Release Notes

52f639f

Yash-cor marked this pull request as draft December 27, 2024 12:49

Solved Spotless and Checkstyle error

949ff51

Yash-cor marked this pull request as ready for review December 27, 2024 13:38

Merge branch 'master' into ISSUE_31437_WITH_KEYWORD_QUERY_ERROR_MYSQL

a27ede2

strongduanmu added type: enhancement in: SQL bind labels Dec 30, 2024

strongduanmu added this to the 5.5.2 milestone Dec 30, 2024

strongduanmu requested changes Dec 30, 2024

View reviewed changes

Merge branch 'apache:master' into ISSUE_31437_WITH_KEYWORD_QUERY_ERRO…

893cea5

…R_MYSQL

Yash-cor marked this pull request as draft December 30, 2024 05:54

Yash-cor added 5 commits December 31, 2024 11:01

Changed the working for Unique Alias Name Exception handling for CTE's

7fbb92f

Update Release Notes

5023a65

Merge branch 'apache:master' into ISSUE_31437_WITH_KEYWORD_QUERY_ERRO…

c340ae3

…R_MYSQL

Changed Release Notes to resolve merge conflict

791c956

Merge remote-tracking branch 'origin/ISSUE_31437_WITH_KEYWORD_QUERY_E…

7a9cd89

…RROR_MYSQL' into ISSUE_31437_WITH_KEYWORD_QUERY_ERROR_MYSQL

Yash-cor added 6 commits December 31, 2024 11:39

Sync With Master Branch

ff11f5e

Removed the Changes for with Clause in DeleteStatement will raise it …

aa99360

…with a different PR.

Merge branch 'apache:master' into ISSUE_31437_WITH_KEYWORD_QUERY_ERRO…

03cc31d

…R_MYSQL

Added SQLBinderIT test case for with clause.

01f9e2f

Merge

30e3647

Merge remote-tracking branch 'origin/ISSUE_31437_WITH_KEYWORD_QUERY_E…

0e7a6f1

…RROR_MYSQL' into ISSUE_31437_WITH_KEYWORD_QUERY_ERROR_MYSQL

Yash-cor marked this pull request as ready for review January 2, 2025 09:43

Yash-cor requested a review from strongduanmu January 2, 2025 09:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue 31437 with keyword query error mysql #34163

Issue 31437 with keyword query error mysql #34163

Yash-cor commented Dec 26, 2024 •

edited

Loading

strongduanmu commented Dec 26, 2024

Yash-cor commented Dec 27, 2024

strongduanmu Dec 30, 2024

Yash-cor Dec 31, 2024

strongduanmu Dec 30, 2024

Yash-cor Dec 31, 2024

strongduanmu Dec 30, 2024

Yash-cor Dec 31, 2024

strongduanmu Dec 30, 2024

Yash-cor Dec 31, 2024

strongduanmu Dec 30, 2024

strongduanmu Dec 30, 2024

Yash-cor Dec 31, 2024

strongduanmu Dec 30, 2024

Yash-cor Dec 31, 2024 •

edited

Loading

strongduanmu Dec 30, 2024

strongduanmu Dec 30, 2024

Yash-cor Dec 31, 2024

strongduanmu Dec 30, 2024

strongduanmu Dec 30, 2024

strongduanmu Dec 30, 2024

Yash-cor Dec 31, 2024

		@@ -47,6 +49,8 @@ public final class SQLStatementBinderContext {

		private final SQLStatement sqlStatement;

		private final Set<CaseInsensitiveString> commonTableExpressionsSegmentsUniqueAliases = new HashSet<>();

		@@ -38,6 +39,8 @@ public final class MySQLDeleteStatement extends DeleteStatement implements MySQL

		private ReturningSegment returningSegment;

		private WithSegment withSegment;

Issue 31437 with keyword query error mysql #34163

Are you sure you want to change the base?

Issue 31437 with keyword query error mysql #34163

Conversation

Yash-cor commented Dec 26, 2024 • edited Loading

Changes proposed in this pull request:

strongduanmu commented Dec 26, 2024

Yash-cor commented Dec 27, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Yash-cor Dec 31, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Yash-cor commented Dec 26, 2024 •

edited

Loading

Yash-cor Dec 31, 2024 •

edited

Loading