Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E2E Test][Improvement] Add Test Case for LocalFile CSV Sink #8436

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

welsh-wen
Copy link
Contributor

@welsh-wen welsh-wen commented Jan 3, 2025

Purpose of this pull request

Add Test Case for LocalFile CSV Sink

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@github-actions github-actions bot added the e2e label Jan 3, 2025
@@ -391,7 +397,7 @@ public void testLocalFileReadAndWrite(TestContainer container)
@TestTemplate
@DisabledOnContainer(
value = {TestContainerId.SPARK_2_4},
type = {EngineType.FLINK},
type = {EngineType.SPARK, EngineType.FLINK},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why disabled spark

@@ -437,6 +443,11 @@ private List<String> getFileListFromContainer(String path) {
}

@TestTemplate
@DisabledOnContainer(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants